Hi,

I found on Google that someone has ported mp3tofid to Mac OS X, and in the way fixed some endian issues.

This darn x86 linux programmer would love to share these fixes so he does not have to make the same mistakes in an upcoming release.

So, send them in, please.

Thanks,
Pim

Haha that's a funny little excerpt there.. What got you to Googling for this? Was it that burning sensation in your ears that you get when someone's talking about you behind your back?

What got you to Googling for this?

For this audience, I narrowed down the search to come up with only one result. (Is that Googlewhacking?). I found this just by searching for mp3tofid.

Was it that burning sensation in your ears that you get when someone's talking about you behind your back?

Yeah, something like your name being part of the answer in a quiz, and you're not there to see it :-)

Pim

Since mp3tofid isn't a real word, you can't consider that a googlewhack. I think I've only ever been able to come up with one solid one.

Bruno

Did we ever track down the changes need to make it work on OSX ?

I've just tried to build the current version, with no luck.

I put a more more effort into trying to build it...

Installed a whole bunch of libraries with MacPorts, tweaked some include/lib paths, added the odd extra include (sys/dir.h), created byteswap.h etc etc

But I still can't get it to build. I am stuck at:

cc -O2 -g -I/opt/local/include -L/opt/local/lib -Wall -Wpointer-arith -Wbad-function-cast -Wcast-align -Wnested-externs -c -o mp3tofid.o mp3tofid.c
mp3tofid.c: In function ‘sourcefiletofidnumber’:
mp3tofid.c:464: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 5 has type ‘ino_t’
mp3tofid.c:466: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 7 has type ‘ino_t’
mp3tofid.c: In function ‘dirscan’:
mp3tofid.c:939: warning: passing argument 4 of ‘scandir’ from incompatible pointer type
cc -O2 -g -I/opt/local/include -L/opt/local/lib -Wall -Wpointer-arith -Wbad-function-cast -Wcast-align -Wnested-externs -c -o scanmp3.o scanmp3.c
cc -O2 -g -I/opt/local/include -L/opt/local/lib -Wall -Wpointer-arith -Wbad-function-cast -Wcast-align -Wnested-externs -c -o scanwave.o scanwave.c
cc -O2 -g -I/opt/local/include -L/opt/local/lib -Wall -Wpointer-arith -Wbad-function-cast -Wcast-align -Wnested-externs -c -o scanwma.o scanwma.c
cc -O2 -g -I/opt/local/include -L/opt/local/lib -Wall -Wpointer-arith -Wbad-function-cast -Wcast-align -Wnested-externs -c -o scanvorbis.o scanvorbis.c
/opt/local/include/vorbis/vorbisfile.h:75: warning: ‘OV_CALLBACKS_DEFAULT’ defined but not used
/opt/local/include/vorbis/vorbisfile.h:82: warning: ‘OV_CALLBACKS_NOCLOSE’ defined but not used
/opt/local/include/vorbis/vorbisfile.h:89: warning: ‘OV_CALLBACKS_STREAMONLY’ defined but not used
/opt/local/include/vorbis/vorbisfile.h:96: warning: ‘OV_CALLBACKS_STREAMONLY_NOCLOSE’ defined but not used
cc -O2 -g -I/opt/local/include -L/opt/local/lib -Wall -Wpointer-arith -Wbad-function-cast -Wcast-align -Wnested-externs -c -o scanflac.o scanflac.c
cc -O2 -g -I/opt/local/include -L/opt/local/lib -Wall -Wpointer-arith -Wbad-function-cast -Wcast-align -Wnested-externs -c -o iconv.o iconv.c
cc -g -L/opt/local/lib -o mp3tofid mp3tofid.o scanmp3.o scanwave.o scanwma.o scanvorbis.o scanflac.o iconv.o -lpopt -lgdbm -lcrypto -lmad -lid3tag -lvorbisfile -lvorbis -logg -lsndfile -lFLAC -lz -lm
Undefined symbols:
"_libiconv", referenced from:
_codesetconv in iconv.o
_codesetconv in iconv.o
"_libiconv_open", referenced from:
_eiconv_open in iconv.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [mp3tofid] Error 1

Any clues anyone ? It is a long time since I was messing about getting random Unix code to build...

Why does this even need compiling -- wouldn't a shell script make more sense?

i'll commit them to git. it's built on osx on my mac and that's how i use it.

a shell script that does what? builds the database? sounds like an icky script.

Awesome. Builds perfectly, one I worked out I was pulling the wrong branch

Thanks

If I would write it again, I'd use Python. I have been considering a rewrite once and then but never got to it.

Pim

Cool. I do own a (Intel) Mac Mini, so I can try this out. Are all the required libraries available as binaries?

I once planned to buy a PPC Mac Mini, and starting coding some byte swap stuff but never finished it as I never bought one.

Thanks for putting mp3tofid into github. Can I get read/write access there? I suppose I could merge most of the changes into master.

Pim

I tried and failed to guess your github username. Just let me know who to add.

As to libraries, I used macports to build what was needed. I believe they distribute them in binary form, also, but I haven't used them, so I can't tell you how to get them.

pimzand

It did not exist when you tried.

Thanks,
Pim

that's ok. also failed to guess who to add for most of the other repos.

Now that we're at it, would it be possible to host my rsync patch for the empeg, now at http://veldhoen.macroscoop.nl/~pim/empeg/rsync, on github as a branch of http://git.samba.org/rsync.git ?

Pim

it's not ideal since a fork won't track, but i'm doing it now.

needs to be updated for current rsync, but branches empeg-vfdhack-1 and empeg-vfdhack-2 now exist in the empeg/rsync github module.

Im just a beginner with git.

I was hoping the distributed workflow stuff that git does would allow a dynamic read-only link to another repo.

Pim

I'm not 100% sure what you mean by this. Generally the distributed stuff is done by each developer having a private repository, and a public-facing repository. If Joe wants changes from Alice, he pulls them from her public repository, into his private repository. When he has changes that he wants to make public to Alice, he pushes his changes from his private repository into his public repository. The project maintainer will generally maintain the "master" public repository by pulling changesets from the contributors' public repositories.

You can pull from multiple repositories, without ever pushing anything back, so in effect, everything is a dynamic read-only link in that regard.

git also has the notion of a submodules, which allows you to create a directory in your tree, and associate that with a particular revision of some other repository. This is what gives you the ability to track dependencies between projects. When you "check out" a git repo containing a submodule, the submodule isn't automatically checked out.

yeah, that would be a tracking repo.