Unoffical empeg BBS

Quick Links: Empeg FAQ | RioCar.Org | Hijack | BigDisk Builder | jEmplode | emphatic
Repairs: Repairs

Topic Options
#83494 - 25/03/2002 19:16 Hijack bug report: Animation does not always play
tfabris
carpal tunnel

Registered: 20/12/1999
Posts: 31600
Loc: Seattle, WA
I've seen this happen twice now, once in the car and once on AC power:

Every once in a while, the animation doesn't play, it just says "Hijack 247 by Mark Lord" for a long time, then the custom logo displays, then the player software boots.

I'm not sure if there are any specific steps to reproduce it.
_________________________
Tony Fabris

Top
#83495 - 25/03/2002 19:40 Hijack v249 [Re: tfabris]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 14496
Loc: Canada
Mmmm.. good one.

There's only one possible cause, no matter how unlikely it may seem to me.. there's a line of code to schedule the beginning of the animation, which looks something like this:

timer.expires = jiffies + hijack_init();
Which should really be something like this instead:

timer.expires = hijack_init() + jiffies;
The hijack_init() routine always returns HZ/3. But.. because hijack_init() also does a flash restore call, which might sometimes take longer than 3/100 of a second if it has to reset the flash buffer chain, it's theoretically possible that the timer expiry might be invalid (a time in the past) by the time the timer gets started..

Such simple things.. look for v249.

-ml

Top
#83496 - 25/03/2002 20:18 Re: Hijack v249 [Re: mlord]
tonyc
carpal tunnel

Registered: 27/06/1999
Posts: 7058
Loc: Pittsburgh, PA
Such simple things..

Simple for you! You kernel guys are another breed!
_________________________
- Tony C
my empeg stuff

Top
#83497 - 25/03/2002 20:27 Re: Hijack v249 [Re: tonyc]
mlord
carpal tunnel

Registered: 29/08/2000
Posts: 14496
Loc: Canada
That's why we get paid the big buc.. er.. whatever.

Cheers

Top